Refactor pipeline parameter options to seperate Options.java file - #4209
Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4209 +/- ##
============================================
+ Coverage 55.92% 61.96% +6.04%
+ Complexity 7483 3451 -4032
============================================
Files 1134 580 -554
Lines 70175 34882 -35293
Branches 8023 3878 -4145
============================================
- Hits 39248 21616 -17632
+ Misses 28380 12157 -16223
+ Partials 2547 1109 -1438
🚀 New features to boost your workflow:
|
aasthabharill
changed the title
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the configuration options for several Dataflow templates by moving them into dedicated Java files. This change enhances code organization and maintainability by decoupling the pipeline configuration definitions from the core template implementation logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the pipeline options for the DataStreamToSpanner, GCSSpannerDV, and SpannerToSourceDb templates by extracting their inner Options interfaces into dedicated classes under a shared options package. Feedback on these changes highlights that excluding these core template classes from code coverage in pom.xml is highly discouraged and out of scope. Additionally, there are duplicate and non-sequential order values in the template parameters of DataStreamToSpannerOptions.java that need to be corrected.
aasthabharill
force-pushed
the
options-refactor
branch
from
September 2, 2026 09:00
b2cb6e4 to
d89acb0
Compare
shreyakhajanchi
approved these changes
Sep 4, 2026
aasthabharill
added a commit
that referenced
this pull request
Sep 7, 2026
) * yml file * yml file * changes * Refactor DataStreamToSpannerOptions to separate file * Delete .github/workflows/codelab-watchdog.yml * Refactor SpannerToSourceDbOptions to separate file * mistakes * Refactor GCSSpannerDVOptions to a separate file * spotless * Fix checkstyle formatting and missing package-info * year * year * fix tests * fix tests * testing * spotless * Fix test compilation failures in SpannerToSourceDbTest * spotless
aasthabharill
added a commit
that referenced
this pull request
Sep 7, 2026
* yml file * yml file * changes * deps: update Python dependencies (#4194) Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com> * [SpannerToSourceDb] Reverse replication Integration test with SSL based connection (#4192) * [SpannerToSourceDb] Reverse replication Integration test with SSL based connection * Moving process creation code into a method * Addressing comments * add auto-close dependabot step for requirements*.txt type files (#4220) * add auto-close dependabot step * add ignore comment * add delta lake to iceberg blueprint and IT (#4103) * add delta lake to iceberg IT * fix spotless and rerun auto-generation * switch to interrupt call * change to a dynamic import to fix error * add forgotten yaml definition file * add generated README for DeltaLakeToIceberg template * switch back to stop method for direct runner * address gemini comment * spotless * initial comments fixes * change iceberg to lakehouse * change to a wrapped writetoiceberg via writetolakehouse * update yaml file with wrapper transform * remove old writetolakehouse transform idea * spotless * change to renamed transform * address Delta client comment * spotless * fix generated file * create write to lakehouse * change package * oops - used wrong assumed date * fix uri catalog version * update jar to to be the same * change to managed and mimic deltalake * update one more version jar * add manifest resource transformer * add managed and iceberg * change pattern * force to schemaAwareExternalTransform * another try * add transformer * update per Cham's comments * fix formatting * fix naming determination (#4210) * fix naming * fix default imports issue * rerun some checks * clean up old named files * change pubsubtoiceberg yaml name * update readme with blueprint naming conventions * Refactor pipeline parameter options to seperate Options.java file (#4209) * yml file * yml file * changes * Refactor DataStreamToSpannerOptions to separate file * Delete .github/workflows/codelab-watchdog.yml * Refactor SpannerToSourceDbOptions to separate file * mistakes * Refactor GCSSpannerDVOptions to a separate file * spotless * Fix checkstyle formatting and missing package-info * year * year * fix tests * fix tests * testing * spotless * Fix test compilation failures in SpannerToSourceDbTest * spotless * change+test * revert test changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com> Co-authored-by: darshan-sj <darshan-sj@users.noreply.github.com> Co-authored-by: Derrick Williams <derrickaw@google.com>
pratickchokhani
pushed a commit
to pratickchokhani/DataflowTemplates
that referenced
this pull request
Sep 7, 2026
…ogleCloudPlatform#4209) * yml file * yml file * changes * Refactor DataStreamToSpannerOptions to separate file * Delete .github/workflows/codelab-watchdog.yml * Refactor SpannerToSourceDbOptions to separate file * mistakes * Refactor GCSSpannerDVOptions to a separate file * spotless * Fix checkstyle formatting and missing package-info * year * year * fix tests * fix tests * testing * spotless * Fix test compilation failures in SpannerToSourceDbTest * spotless
pratickchokhani
pushed a commit
to pratickchokhani/DataflowTemplates
that referenced
this pull request
Sep 7, 2026
…ogleCloudPlatform#4209) * yml file * yml file * changes * Refactor DataStreamToSpannerOptions to separate file * Delete .github/workflows/codelab-watchdog.yml * Refactor SpannerToSourceDbOptions to separate file * mistakes * Refactor GCSSpannerDVOptions to a separate file * spotless * Fix checkstyle formatting and missing package-info * year * year * fix tests * fix tests * testing * spotless * Fix test compilation failures in SpannerToSourceDbTest * spotless
pratickchokhani
pushed a commit
to pratickchokhani/DataflowTemplates
that referenced
this pull request
Sep 7, 2026
…#4206) * yml file * yml file * changes * deps: update Python dependencies (GoogleCloudPlatform#4194) Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com> * [SpannerToSourceDb] Reverse replication Integration test with SSL based connection (GoogleCloudPlatform#4192) * [SpannerToSourceDb] Reverse replication Integration test with SSL based connection * Moving process creation code into a method * Addressing comments * add auto-close dependabot step for requirements*.txt type files (GoogleCloudPlatform#4220) * add auto-close dependabot step * add ignore comment * add delta lake to iceberg blueprint and IT (GoogleCloudPlatform#4103) * add delta lake to iceberg IT * fix spotless and rerun auto-generation * switch to interrupt call * change to a dynamic import to fix error * add forgotten yaml definition file * add generated README for DeltaLakeToIceberg template * switch back to stop method for direct runner * address gemini comment * spotless * initial comments fixes * change iceberg to lakehouse * change to a wrapped writetoiceberg via writetolakehouse * update yaml file with wrapper transform * remove old writetolakehouse transform idea * spotless * change to renamed transform * address Delta client comment * spotless * fix generated file * create write to lakehouse * change package * oops - used wrong assumed date * fix uri catalog version * update jar to to be the same * change to managed and mimic deltalake * update one more version jar * add manifest resource transformer * add managed and iceberg * change pattern * force to schemaAwareExternalTransform * another try * add transformer * update per Cham's comments * fix formatting * fix naming determination (GoogleCloudPlatform#4210) * fix naming * fix default imports issue * rerun some checks * clean up old named files * change pubsubtoiceberg yaml name * update readme with blueprint naming conventions * Refactor pipeline parameter options to seperate Options.java file (GoogleCloudPlatform#4209) * yml file * yml file * changes * Refactor DataStreamToSpannerOptions to separate file * Delete .github/workflows/codelab-watchdog.yml * Refactor SpannerToSourceDbOptions to separate file * mistakes * Refactor GCSSpannerDVOptions to a separate file * spotless * Fix checkstyle formatting and missing package-info * year * year * fix tests * fix tests * testing * spotless * Fix test compilation failures in SpannerToSourceDbTest * spotless * change+test * revert test changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com> Co-authored-by: darshan-sj <darshan-sj@users.noreply.github.com> Co-authored-by: Derrick Williams <derrickaw@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.